Skip to content

Remove Live Now new-feature nudge - #11604

Open
mozzius wants to merge 1 commit into
mainfrom
samuel/app-2994-remove-live-now-nudge
Open

Remove Live Now new-feature nudge#11604
mozzius wants to merge 1 commit into
mainfrom
samuel/app-2994-remove-live-now-nudge

Conversation

@mozzius

@mozzius mozzius commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the Live Now notification dot and promotional styling from the profile menu
  • remove the obsolete LiveNowBetaNudge state and dismissal write
  • preserve the existing Go Live entry point and dialogs

APP-2994

Test plan

  • Open your profile and confirm the overflow button has no Live Now notification dot.
  • Open the overflow menu and confirm Go live uses standard styling and still opens the existing Live Now flow.

@linear-code

linear-code Bot commented Aug 28, 2026

Copy link
Copy Markdown

APP-2994

@claude

claude Bot commented Aug 28, 2026

Copy link
Copy Markdown

Claude finished @mozzius's task in 1m 7s —— View job


Review: Remove Live Now new-feature nudge

I read the repo's CLAUDE.md and .github/claude-review-prompt.md, then reviewed both changed files and traced the removed symbols across the codebase.

This PR looks good — no blocking or non-blocking findings.

What I checked:

  • definitions.ts — the LiveNowBetaNudge removal is consistent across all three places it appears: the Nux enum, the AppNux union, and the NuxSchemas record. Because nuxNames is derived from Object.values(Nux), parseAppNux (src/state/queries/nuxs/util.ts:12) will now simply drop any LiveNowBetaNudge record still stored server-side for existing users — this is the normal, safe retirement path (no crash, no orphaned union member). LiveNowBetaDialog is intentionally retained.
  • ProfileMenu.tsx — the nudge state (statusNudge/statusNudgeActive/saveNux), the notification Dot, the Gradient promo styling, the "New" badge, and the primary-color LiveIcon fill are all removed. The saveNux(... LiveNowBetaNudge ...) dismissal write inside the Go live onPress is correctly dropped along with it, and the Go live entry point + dialogs (GoLiveDialog, GoLiveDisabledDialog, EditLiveDialog) are preserved.
  • Dead imports — every import that became unused is removed (Nux/useNux/useSaveNux, atoms as a/useTheme, Dot, Gradient) and the const t = useTheme() binding is gone. Confirmed no leftover t./a. references remain in the file. IS_WEB is retained and still used (lines 305/314/321).
  • Repo-wide grep for LiveNowBetaNudge, statusNudge, and statusNudgeActive returns zero remaining references.

The hitSlop comment about the iOS tap-stealing behavior is preserved through the fragment→single-element simplification, so that context isn't lost.
· samuel/app-2994-remove-live-now-nudge

@ds-boyce ds-boyce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟥🟥🟥🟥

@github-actions

Copy link
Copy Markdown
Contributor
Old size New size Diff
8.06 MB 8.06 MB -1.88 KB (-0.02%)

@github-actions

Copy link
Copy Markdown
Contributor

The OTA deployment for this PR was successful! You may now apply it by either scanning the QR code or opening the deep link below in your browser:

QR code for the PR OTA deployment

bluesky://intent/apply-ota?channel=pull-request-11604&releaseVersion=1.132.0&iosBuildNumber=2053&androidBuildNumber=1530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants