Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 68.83% 68.90% +0.07%
==========================================
Files 14 14
Lines 1832 1833 +1
==========================================
+ Hits 1261 1263 +2
+ Misses 571 570 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Here's one of the cases I want to test, with different values for acquire_time = 0.01
gap_between_frames = 0.001
num_acquire = 2 # num arg to count plan
num_exposures = 1 # number of camera exposures per frame (not supported by all detectors)
num_images = 3 # number of frames per acquire
adsimdet.cam.stage_sigs["acquire_time"] = acquire_time
adsimdet.cam.stage_sigs["image_mode"] = "Multiple"
adsimdet.cam.stage_sigs["num_exposures"] = num_exposures
adsimdet.cam.stage_sigs["num_images"] = num_images
adsimdet.hdf1.stage_sigs["num_capture"] = num_images
adsimdet.hdf1.stage_sigs.move_to_end("capture", last=True)I'm expecting a 4-D dataset: (2, 3, nx, ny) but the HDF5 file data has shape (3, nx, ny). Inspecting how bluesky.plans.count works, the detector is staged, then iterates over num_acquire. The HDF5 plugin is not staged for additional acquisitions. Not a situation to be fixed here, but one of the challenges in reviewing. |
|
Acquisition results in a single resource and two datum docs. (uid,) = RE( # noqa
bp.count( # noqa
[adsimdet],
num_acquire,
md=dict(
title="Area Detector with default HDF5 File Name",
purpose="image"),
)
)
run = cat[uid]but tiled client fails to get the dataset: dataset = run.primary.read()(10 tries resulting in |
|
Setting |
This enables support for consolidating datasets that consist of multiple hdf5 files. The
HDF5Adapterin Tiled already can accept multiple uris and concatenate them into a single array. However, if the filenames are passed in the Resource document in the form of a template,HDF5Consolidatordid not have the ability to register these files per each Datum (as done for sequences of tiff or jpeg file inMultipartRelatedConsolidator).This PR declares a new
MultipartHDF5Consolidatorto be used for datasets of"application/x-hdf5"mimetype, but only if the Resource document declares a"template"inresource_kwargs(orparametersinStreamResource). Otherwise, the usualHDF5Consolidatoris used for the same mimetype.Related discussion in Mattermost: https://mattermost.hzdr.de/bluesky/pl/uhpt8h54bpn9iyoxpb65tupr9y