ENH: drop python 3.8, 3.9 and support 3.13 #368
+303
−305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacopoabramo
changed the title
- was used for python<3.9, which this PR should remove support for
jacopoabramo
commented
Oct 6, 2025
jacopoabramo
commented
Oct 6, 2025
jacopoabramo
commented
Oct 6, 2025
Contributor
Author
|
@evvaaaa any suggestions? Apparently some fields have been changed from |
evvaaaa
requested changes
Oct 7, 2025
Contributor
evvaaaa
left a comment
evvaaaa
left a comment
There was a problem hiding this comment.
This would be nice, however, bluesky supports 3.9 still, and event-model is a required dependency. I wouldn't be happy updating this without also dropping 3.9 from bluesky.
Contributor
Author
There's a PR open for that. Once that's merged, this can be merged as well safely I believe |
- for some reason previous regeneration didn't update the json files
evvaaaa
approved these changes
Oct 7, 2025
Contributor
evvaaaa
left a comment
evvaaaa
left a comment
There was a problem hiding this comment.
To be merged alongside the bluesky update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #367 and #354
Motivation and Context
Python 3.9 reaches EOL end of this month; this is an attempt to mirror bluesky repo.
Currently blocked by #1959
How Has This Been Tested?
Tested locally but some changes due to autogenerating typed dictionary models are fishy.