Removing unnecessary TangoReadable class #1130
Merged
+24
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, simply inherit from TangoDevice and StandardReadable. Added set_trl method to TangoDeviceConnector to change the trl before connecting the device. Previously this was done by accessing the public trl attribute directly. In TangoDevice, trl was given a default value to allow for setting the trl after initialization.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unnecessary
TangoReadableclass. For equivalent functionality, simply inherit fromTangoDeviceandStandardReadable. Addedset_trlmethod toTangoDeviceConnectorto change the trl before connecting the device. Previously this was done by accessing the publictrlattribute directly. InTangoDevice,trlwas given a default value of an empty string to allow for setting thetrlafter initialization.Fixes #757