1163 support signal[t] | none syntax in devicefiller

[LuisFSegalla]

Addresses #1163

[coretl]

Why is this needed? All optional devices should have been created in mock mode so there should be no need to call this function...

[LuisFSegalla]

I added this so that when trying to connect check_filled would be called testing the added code to create the disconnected attr. Otherwise no other part of the mock code calls for filler.check_filled().

[coretl]

Ok, please remove this line and add a test that instantiates DeviceFiller manually on a Device with both mandatory and optional Signals, then calls check_filled to check its failure and success paths.

[coretl]

I would expect the signal to exist here

[LuisFSegalla]

You're right, that was my mistake, I'll fix it.

[coretl]

@claude suggest code for the test mentioned in #1165 (comment)

[claude]

Claude finished @coretl's task in 2m 40s —— View job

---

Test implementation completed

Tasks:

• Read the modified files to understand the implementation
• Read existing tests to understand test patterns
• Remove line at _pvi_connector.py:117 as requested
• Create new test that instantiates DeviceFiller manually with mandatory and optional Signals
• Test both success and failure paths of check_filled
• Commit and push changes

Changes Made

I've implemented the test as requested in the review comment:

1. Removed unnecessary line from _pvi_connector.py:117

• Removed the self.filler.check_filled("") call from connect_mock method

2. Added comprehensive test in test_device.py

• Created test_device_filler_check_filled_with_optional_signals()
• Manually instantiates DeviceFiller with a test Device containing:
  • mandatory_signal: SignalRW[int] - a required signal
  • optional_signal: SignalRW[int] | None - an optional signal
• Tests failure path: check_filled raises RuntimeError when mandatory signal is unfilled
• Tests success path: After filling mandatory signal, check_filled succeeds and sets optional signal to None

3. Updated comment in test_pvi.py

• Clarified that the test checks optional signal behavior

The test verifies that DeviceFiller correctly:

• Identifies signals with T | None annotations as optional
• Raises errors when mandatory signals are unfilled
• Sets optional signals to None when they remain unfilled
• Allows successful connection when all mandatory signals are filled

--- | Branch

[coretl]

Suggested change

	f"{self._device.name}: cannot provision {unfilled} from {source}"
	f"{self._device.name}: cannot provision {unfilled_mandatory} from {source}"