Expand assert_* functions to work with all signal types#711
Merged
Conversation
88cd1b6 to
fb82b42
Compare
fb82b42 to
9105b63
Compare
coretl
reviewed
Dec 18, 2024
a88e533 to
81f951f
Compare
Collaborator
|
#714 adds pytest assert rewriting, so you can ditch the custom error messages, and also an |
81f951f to
93fdbf9
Compare
coretl
reviewed
Jan 6, 2025
93fdbf9 to
c7159aa
Compare
coretl
reviewed
Jan 6, 2025
Contributor
|
This might link to #710 |
Collaborator
The |
42d1170 to
d59c035
Compare
coretl
reviewed
Jan 8, 2025
Collaborator
coretl
left a comment
There was a problem hiding this comment.
One minor comment then we're good to go!
840dd23 to
714d117
Compare
714d117 to
0d040a6
Compare
coretl
approved these changes
Jan 14, 2025
added 3 commits
January 17, 2025 08:49
… OneOfEverythingDevice
Remove explicit signal names in OneOfEverythingDevice
0d040a6 to
0057179
Compare
Collaborator
|
Feel free to merge this when you're ready |
paula-mg
pushed a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #707
Fixes #717
Expands OneOfEveryThingDevice into a StandardDetector so we can call read_configuration, and adds tests to tests/core/test_signal.py.
pytest.approx does not work on a whole dict when Tables are present, so now having to manually loop over each key in a dict[str, Reading], but now assert_reading, assert_value and assert_configuration work with arrays and table types.