Adding ConfigSignal version of get_current_settings and retrieve_settings.#803
Merged
Adding ConfigSignal version of get_current_settings and retrieve_settings.#803
Conversation
…es in StandardReadable devices
…I moved it back to _signal.py. The test should work now.
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
…nt_config_settings and retrieve_config_settings.
coretl
reviewed
Feb 28, 2025
Collaborator
coretl
left a comment
coretl
left a comment
There was a problem hiding this comment.
Rather than duplicate the plans, would it be better to add an only_config=False arg to each of the existing plans?
…and retrieve_settings to optionally only handle configuration signals instead of all SignalRWs.
shihab-dls
pushed a commit
that referenced
this pull request
Mar 6, 2025
…ings. (#803) * Variation of store_settings which only handles configuration attributes in StandardReadable devices * Moved walk_config_signals to _readable * defined config_names before loop * walk_config_signals now checks for bluesky.protocols.Configurable so I moved it back to _signal.py. The test should work now. * Ran ruff * Clearing pre-commit,typechecking with tox * Update src/ophyd_async/core/_signal.py Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com> * Reverted suggested change * Added config signal only plans to handle settings including get_current_config_settings and retrieve_config_settings. * Added only_config=False kwarg to store_config, get_current_settings, and retrieve_settings to optionally only handle configuration signals instead of all SignalRWs. --------- Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
paula-mg
pushed a commit
that referenced
this pull request
Mar 26, 2025
…ings. (#803) * Variation of store_settings which only handles configuration attributes in StandardReadable devices * Moved walk_config_signals to _readable * defined config_names before loop * walk_config_signals now checks for bluesky.protocols.Configurable so I moved it back to _signal.py. The test should work now. * Ran ruff * Clearing pre-commit,typechecking with tox * Update src/ophyd_async/core/_signal.py Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com> * Reverted suggested change * Added config signal only plans to handle settings including get_current_config_settings and retrieve_config_settings. * Added only_config=False kwarg to store_config, get_current_settings, and retrieve_settings to optionally only handle configuration signals instead of all SignalRWs. --------- Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added config signal only plans to handle settings including get_current_config_settings and retrieve_config_settings. Not sure if I handled the tests correctly. I had to create a new test_data file for OneOfEverythingDevice.