Allow None in Shapes #895
Merged
Allow None in Shapes #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Willemsen
force-pushed
the
allow_none_in_shape
branch
from
c7eeb73 to
ad8df5c
Compare
Tom-Willemsen
force-pushed
the
allow_none_in_shape
branch
from
ad8df5c to
3bbf66a
Compare
coretl
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bluesky/event-model#352, bluesky descriptors are allowed to contain
Nonein the shape (meaning unknown or variable length for that dimension).This is an initial pass at broadening the type hints of
shapein ophyd-async to allow this to be used.I've made the areadetector implementation error on this for now, as it's not clear to me whether areadetector can conceptually do this, or how to deal with chunking. Happy to defer to areadetector users on best behaviour there.