Skip to content

Allow None in Shapes #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Allow None in Shapes #895

merged 1 commit into from
Jun 2, 2025

Conversation

Tom-Willemsen
Copy link
Member

After bluesky/event-model#352, bluesky descriptors are allowed to contain None in the shape (meaning unknown or variable length for that dimension).

This is an initial pass at broadening the type hints of shape in ophyd-async to allow this to be used.

I've made the areadetector implementation error on this for now, as it's not clear to me whether areadetector can conceptually do this, or how to deal with chunking. Happy to defer to areadetector users on best behaviour there.

@Tom-Willemsen Tom-Willemsen force-pushed the allow_none_in_shape branch from c7eeb73 to ad8df5c Compare May 16, 2025 10:20
@Tom-Willemsen Tom-Willemsen force-pushed the allow_none_in_shape branch from ad8df5c to 3bbf66a Compare May 16, 2025 12:38
@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review May 16, 2025 15:06
@Tom-Willemsen Tom-Willemsen merged commit ffe81b9 into main Jun 2, 2025
41 of 42 checks passed
@Tom-Willemsen Tom-Willemsen deleted the allow_none_in_shape branch June 2, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants