Skip to content

Minor improvements to sim.py module #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tacaswell wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Minor improvements to sim.py module #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ba6a96
MNT: account for flake8 6
tacaswell Dec 9, 2022
5789fa0
ENH: give SynAxis a nice repr
tacaswell Dec 9, 2022
52b199d
FIX: force EnumSignal to claim to be a string
tacaswell Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ophyd/sim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def get(self, *, as_string=True, **kwargs):
def describe(self):
desc = super().describe()
desc[self.name]["enum_strs"] = self._enum_strs
desc[self.name]['dtype'] = 'string'
Copy link
Member

@mrakitin mrakitin Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions from linter:

Suggested change
desc[self.name]['dtype'] = 'string'
desc[self.name]["dtype"] = "string"

return desc


Expand Down Expand Up @@ -424,6 +425,9 @@ class SynAxis(Device):
SUB_READBACK = "readback"
_default_sub = SUB_READBACK

def __repr__(self):
return f"{self.__class__.__name__}(name={self.name!r})"

def __init__(
self,
*,
Expand Down
9 changes: 6 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,12 @@ max-line-length = 115
extend-ignore =
W504,
W503,
E203, # See https://github.com/PyCQA/pycodestyle/issues/373
F811, # support typing.overload decorator
F722, # allow Annotated[typ, some_func("some string")]
# See https://github.com/PyCQA/pycodestyle/issues/373
E203,
# support typing.overload decorator
F811,
# allow Annotated[typ, some_func("some string")]
F722,
exclude =
ui_*
.tox
Expand Down