Add two new kwargs to ADTriggerStatus __init__, to allow for using different signals than default AD #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems reasonable, but needs updates to docstring please. |
Member
Author
|
Hm. Not sure why those commits are now included here since they are already merged with master. Let me clean this up. |
…fferent signals than default AD
tacaswell
force-pushed
the
make-adtriggerstatus-reusable
branch
from
0033f48 to
7e5e723
Compare
Contributor
|
I think you did a rebase, merge from your remote, push cycle. I rebased and force-pushed for you. |
tacaswell
reviewed
Apr 16, 2024
| A special status object that notifies watches (progress bars) | ||
| based on comparing device.cam.array_counter to device.cam.num_images. | ||
| based on comparing the two signal values counter_signal and |
Contributor
There was a problem hiding this comment.
Can this be a numpydoc style docstring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ADTriggerStatusessentially hard codes the two signals that are watched/compared when reporting the progress of a trigger execution. I know of at least a few cases where this isn't desirable due to either non-standard AD driver behavior, or because the underlying detector relies on a different progress metric than completed/readout frames.I'd like to get some feedback on whether or not this approach is reasonable, and if yes I can write up a unit test or two to check behavior when either or both signals are overridden.