Add OrStatus, improve error propagation for AndStatus #1266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an OrStatus objects and slightly improves error handling in the AndStatus. It was separated and refactored based on comments in #1265 (#1265 (comment)).
Use Case
In some cases, multiple status objects are created from methods or
setcalls. In some cases, it can be preferable to combine these status objects to hand them over to a different section in the code. This was already possible with the AndStatus object, however, the error handling in case of a failure was not optimal as the actual Exception leading to the status to fail was not properly propagated. This PR fixes this. In addition, a second option was added to combine status objects with a logicalor. Here, the idea is that it will resolve in success if any of the status objects succeeds, and only fails if a single status object fails.AndStatus
OrStatus