Remove SpecialUsers principals#1065
Merged
danielballan merged 7 commits intobluesky:mainfrom Aug 26, 2025
Merged
Conversation
danielballan
reviewed
Aug 6, 2025
Member
danielballan
left a comment
danielballan
left a comment
There was a problem hiding this comment.
I like this so much.
In addition to the nits marked in line, we should give attention to how to differentiate authenticated and unauthenticated requests in log messages, in the case of the single-user server. (The multi-user server will log clearly as is.)
Member
|
Note from design discussion: For multi-user server, send the logging filter a Principal or None. For single-user server, send the logging filter either:
|
danielballan
reviewed
Aug 6, 2025
nmaytan
commented
Aug 14, 2025
nmaytan
force-pushed
the
remove_specialusers
branch
from
b68cb6d to
a027746
Compare
danielballan
approved these changes
Aug 26, 2025
nmaytan
force-pushed
the
remove_specialusers
branch
from
a027746 to
cf0da9e
Compare
danielballan
approved these changes
Aug 26, 2025
ZohebShaikh
pushed a commit
that referenced
this pull request
Feb 21, 2026
* Remove SpecialUsers principals * Remove SpecialUsers from Simple policy * Minor cleanups * Use SingleUser sentinel for 'single user with api key' mode * Remove SpecialUsers from zarr endpoints * Update changelog to catch up with releases * Update changelog for new release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #923, with follow-up authZ work in #1008
Checklist