ποΈ Add an arbitrary limit on assets that can be placed in a tiled collection#1264
Open
Kezzsim wants to merge 7 commits intobluesky:mainfrom
Open
ποΈ Add an arbitrary limit on assets that can be placed in a tiled collection#1264Kezzsim wants to merge 7 commits intobluesky:mainfrom
Kezzsim wants to merge 7 commits intobluesky:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #692 by adding a settable environment variable
TILED_ASSET_LIMITwith a default value of100000.This is to speed up non-paginated loding tasks.
TODO:
Please note, if there are multiple concurrent transactions attempting inserts simultaneously there is a chance that a number of records exceeding the maximum may be added. It is widely considered impossible to set a hard limit using a trigger.
That being said, going 1-5 documents over such an arbitrary limit should be acceptable.