WIP: Implement Efficient Array Slicing and Minimal Requests from the Client#1302
Draft
genematx wants to merge 13 commits intobluesky:mainfrom
Draft
WIP: Implement Efficient Array Slicing and Minimal Requests from the Client#1302genematx wants to merge 13 commits intobluesky:mainfrom
genematx wants to merge 13 commits intobluesky:mainfrom
Conversation
| # This will be used to determine how to combine multiple requests when fetching | ||
| # data in blocks. If set to None, the client will not attempt to combine | ||
| # requests and will fetch each chunk separately as determiied by the structure. | ||
| RESPONSE_BYTESIZE_LIMIT = 250 * 1024 * 1024 # 250 MiB |
Member
There was a problem hiding this comment.
Without evidence, I would guess that the benefits of parallelism show up before 250 MiB. Some basic performance testing (over LAN and WAN) would be worthwhile, I think. We don't have to optimize it perfectly in this first pass, but I would like some evidence to base this number on initially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds to possibility to request larger blocks spanning multiple contiguous chunks in a single request. For this, the
?block=query parameter has been expanded to accept slices in addition to integer indexes.Additionally, it improves the Python client by allowing it to request only the necessary data if an array is sliced, instead of downloading an entire array and slicing it afterwards.
Checklist