Skip to content

tree util may skip errors #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielballan
Copy link
Member

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

Closes #888

Tested on a directory with a single HDF5 file with a broken external link. In main, I can reproduce #888:

❯ tiled tree --profile local
└── stuff
    └── main
<snipped traceback>
HTTPStatusError: Server error '500 Internal Server Error' for url 'http://localhost:8000/api/v1/search/stuff/main?page%5Boffset%5D=0&sort='

In this PR branch:

❯ tiled tree --profile local
└── stuff
    └── main
SKIPPING due to error: Server error '500 Internal Server Error' for url 'http://localhost:8000/api/v1/search/stuff/main?page%5Boffset%5D=0&sort='
For more information, server admin can search server logs for correlation ID 87d503846a48e9c3.

In both cases, server logs:

KeyError: "Unable to synchronously open object (unable to open external file, external link file name = 'source.h5')"

@danielballan
Copy link
Member Author

Interesting. When I add a second file, to verify that tree continues on past the broken file, I get this.

SKIPPING due to error: [Errno 104] Connection reset by peer

Needs more investigation, not sure where that would be coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree falls on broken external HDF5 links
1 participant