-
Notifications
You must be signed in to change notification settings - Fork 10
Refactor Document Access Feature (Client and ServerSide) #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…luewave-dataroom into refactor/document-access
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I just wanted to mention that on the document page, we're encountering a server error (500) related to displaying documents in the table. As a result, we can't upload documents, and there's an error associated with that as well.
Also, since the name of the link has been changed to documentLink in the Schema file, it might be better to update the corresponding name like linkId in shared/models/linkModels.ts to match that for consistency in the future.
…nd explicit interfaces
This PR Fixes
This Pull Request will cover the refactor of document access feature:
visitorMetaData
alias
is unique as per a single user only. The below Query will support adding alias with more and one empty and null values but not any scalar values. We need to create a migration and run this query.To look the UI Changes please go through this merged PR created by @SepidehShahbazi
Overhauling CreateLink modal and SendingAccordion, and adding React Query