feat: add bmad-checkpoint-preview skill#2145
Merged
Conversation
🤖 Augment PR SummarySummary: This PR introduces a new implementation-phase skill, Changes:
Technical Notes: Workflow loads module config via 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-02-walkthrough.md
Outdated
Show resolved
Hide resolved
src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-03-detail-pass.md
Outdated
Show resolved
Hide resolved
src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-01-orientation.md
Outdated
Show resolved
Hide resolved
📝 WalkthroughWalkthroughThis PR introduces documentation for a new "bmad-checkpoint-preview" skill, defining a structured code review workflow. It includes a skill entry point, main workflow configuration, and four sequential review steps (orientation, walkthrough, detail pass, testing) that guide reviewers through analyzing changes with specific procedures for understanding scope, organizing concerns, identifying risks, and verifying behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/bmm-skills/4-implementation/bmad-checkpoint-preview/workflow.md (1)
20-20: Consider clarifying the phrasing."YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style" has slightly awkward phrasing. Consider: "Format all output according to your agent communication style for
{communication_language}" or "All output must use the agent communication style specified by{communication_language}".✨ Proposed refinement
-YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`. +Format all output according to your agent communication style for `{communication_language}`.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/bmm-skills/4-implementation/bmad-checkpoint-preview/workflow.md` at line 20, The sentence "YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`." is awkwardly phrased; update the line in workflow.md (the string containing that exact sentence) to clearer wording such as "Format all output according to your agent communication style for `{communication_language}`" or "All output must use the agent communication style specified by `{communication_language}`" so the intent is unambiguous and reads naturally.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-01-orientation.md`:
- Line 56: Replace the shortened empty-tree SHA used in the "Bare commit"
example (currently `4b825dc`) with the full hash
`4b825dc642cb6eb9a060e54bf8d69288fbee4904` so the diff command
(`4b825dc..commit` example) works reliably; update the line that reads "**Bare
commit**: Diff against parent (`commit~1..commit`). For merge commits, use
`--first-parent`. For initial commits, diff against the empty tree
(`4b825dc..commit`)." to use the full SHA instead of the shortened form.
---
Nitpick comments:
In `@src/bmm-skills/4-implementation/bmad-checkpoint-preview/workflow.md`:
- Line 20: The sentence "YOU MUST ALWAYS SPEAK OUTPUT in your Agent
communication style with the config `{communication_language}`." is awkwardly
phrased; update the line in workflow.md (the string containing that exact
sentence) to clearer wording such as "Format all output according to your agent
communication style for `{communication_language}`" or "All output must use the
agent communication style specified by `{communication_language}`" so the intent
is unambiguous and reads naturally.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a08044fb-c3f9-4cc2-83d7-91f407ddff43
⛔ Files ignored due to path filters (1)
src/bmm-skills/module-help.csvis excluded by!**/*.csv
📒 Files selected for processing (6)
src/bmm-skills/4-implementation/bmad-checkpoint-preview/SKILL.mdsrc/bmm-skills/4-implementation/bmad-checkpoint-preview/step-01-orientation.mdsrc/bmm-skills/4-implementation/bmad-checkpoint-preview/step-02-walkthrough.mdsrc/bmm-skills/4-implementation/bmad-checkpoint-preview/step-03-detail-pass.mdsrc/bmm-skills/4-implementation/bmad-checkpoint-preview/step-04-testing.mdsrc/bmm-skills/4-implementation/bmad-checkpoint-preview/workflow.md
src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-01-orientation.md
Outdated
Show resolved
Hide resolved
Copies the av-human-review experiment skill into BMAD-METHOD as bmad-checkpoint, following established multi-step skill conventions (SKILL.md → workflow.md → step chain). Registered in module-help.csv under 4-implementation phase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ep rules Remove separate workflow.md — its content now lives directly in SKILL.md with merged frontmatter. Replace scattered standing rules with a structured Global Step Rules section (path:line format, front-load output, comm style).
Steps 2–4 now reference Global Step Rules in SKILL.md instead of restating path:line format, front-load, and silence rules locally. Step-specific rules (concern-based org, design judgment, risk awareness, experiential testing) are preserved.
SKILL.md frontmatter should only contain name and description. Hardcode the config path inline in the INITIALIZATION section.
Rewrite description to reflect the skills purpose as an LLM-assisted human-in-the-loop review. Add checkpoint trigger, drop stale triggers.
…ken budget Use CWD-relative path:line in fallback trail (not markdown links), cap full-file reads at ~50k tokens, remove over-prompted empty-tree SHA. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
alexeyv
force-pushed
the
feat/bmad-checkpoint
branch
from
92b7150 to
beeb2e1
Compare
…scade Replace the ad-hoc change-finding logic with a clean 1-5 cascade modeled after quick-dev Intent Check: explicit argument, recent conversation, sprint tracking, current git state, ask. Extract spec/commit pairing into a separate ENRICH step that runs after any cascade level resolves. Add planning_artifacts to SKILL.md initialization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… step-01 Replace opaque Review Mode table with explicit set-variable instructions. Scope terse commit message handling to bare-commit mode only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… bullets Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…scade Replace rigid with-spec/bare-commit split with a 4-level fallback: baseline_commit, merge-base, HEAD~1, skip. Omit metrics that cannot be computed rather than failing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-trail.md Reduce step-01 bloat by moving the conditional trail generation sub-routine into its own file, loaded only when review mode is not full-trail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace undefined "I've seen enough" exits with proper early-exit handling across steps 02-04. Extract wrap-up logic into dedicated step-05-wrapup.md. Fix step-02 menu text that incorrectly promised "code review" when step-03 does risk surfacing.
Collaborator
Author
Triage Complete: 4 findings — FIX: 2, DISMISS: 2, DEFER: 0
Fix Details
Dismissal Rationale
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bmad-checkpoint-previewskill tosrc/bmm-skills/4-implementation/— a guided, concern-ordered change walkthrough for human review of commits, branches, or PRsav-human-reviewexperiment skill, adapted to BMAD multi-step conventions (SKILL.md → workflow.md → step chain)module-help.csv(sequence 55, post-Code Review)Test plan
npm ci && npm run qualityin the worktree🤖 Generated with Claude Code