-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix(checkpoint): address review findings from adversarial triage #2180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,14 +11,14 @@ Display: `Orientation → [Walkthrough] → Detail Pass → Testing` | |
|
|
||
| ### Identify Concerns | ||
|
|
||
| **With Suggested Review Order** (`full-trail` mode): | ||
| **With Suggested Review Order** (`full-trail` mode — the normal path, including when step-01 generated a trail): | ||
|
|
||
| 1. Read the Suggested Review Order stops from the spec (or from conversation context if generated by step-01 fallback). | ||
| 2. Resolve each stop to a file in the current repo. Output in `path:line` format per the standing rule. | ||
| 3. Read the diff to understand what each stop actually does. | ||
| 4. Group stops by concern. Stops that share a design intent belong together even if they're in different files. A stop may appear under multiple concerns if it serves multiple purposes. | ||
|
|
||
| **Without Suggested Review Order** (`spec-only` or `bare-commit` mode): | ||
| **Without Suggested Review Order** (fallback when trail generation failed, e.g., git unavailable): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
|
|
||
| 1. Get the diff against the appropriate baseline (same rules as step 1). | ||
| 2. Identify concerns by reading the diff for cohesive design intents: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step-01-orientation.md:101+generate-trail.md’s “return to step-01” instruction can accidentally create a loop where trail generation keeps being retried whenreview_moderemains non-full-trail(e.g., git unavailable). Consider clarifying how to proceed tostep-02after a failed attempt without re-invoking./generate-trail.md.Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.