-
-
Notifications
You must be signed in to change notification settings - Fork 18
Add Regression Test for Low Energy Tracking Through Buncher Cavity #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Regression Test for Low Energy Tracking Through Buncher Cavity #1763
Conversation
@electronsandstuff Looks like there are conflicts there that need to be resolved. Note: I did just add a test for this on my side. |
OK, resolved if you want to add this one too. |
@electronsandstuff Looks like now there are failing tests... |
I assume by "issue" you mean #1762. See my comment at the end of this issue. The fact that there is a difference now as compared to 20250915.0 is to be expected. |
Sorry if I am misunderstanding something, but I am still confused. I know that In the older Bmad version, the code says that the bunch gains 100keV through the cavity. In the latest Bmad, the bunch's energy doesn't change (no change in |
Yes there has been a change and the results are not consistent. What the code did in the past was not what a User would expect so this has changed. |
If you want we can zoom and I can explain in detail. |
OK, thanks. I will reach out to you over slack. In the meantime it sounds like this test isn't correct and I can close out the PR. |
This PR adds an accompanying regression test and minimum working example for #1762.