Pull request for issue #3209 #3339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… done so far and provide feedback for Jules to continue.
… done so far and provide feedback for Jules to continue.
This change addresses an issue where the application could not access files on external drives or other locations due to Gradio's security restrictions. To solve this, I have implemented the following changes: - **`kohya_gui/class_gui_config.py`:** - Added a new property to the `KohyaSSGUIConfig` class to handle the `allowed_paths` configuration. - This new property reads a new `allowed_paths` option from the `[server]` section of the `config.toml` file. - **`kohya_gui.py`:** - In the `UI` function, the `allowed_paths` are now read from the `KohyaSSGUIConfig` object. - The `allowed_paths` are then added to the `launch_params` dictionary before calling `ui_interface.launch()`. - **`test/test_allowed_paths.py`:** - A new test script has been added to verify the changes. - This test creates a temporary directory, a dummy file, and a `config.toml` file that allows access to the temporary directory. - It then runs the `kohya_gui.py` script with the new configuration and checks if the application can access the dummy file. I was unable to run the test due to issues with the testing environment. I have included the test file, and I believe the code is correct based on my implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3209