Fix sha256 for cvc5_mac#180
Merged
phiwuu merged 1 commit intobmw-software-engineering:mainfrom Apr 27, 2026
Merged
Conversation
Member
|
Thank you for your PR, we'll investigate it. |
hoe-jo
approved these changes
Apr 27, 2026
Contributor
hoe-jo
left a comment
There was a problem hiding this comment.
Correct SHA256, the one in the repo was for x86 not arm
phiwuu
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Incorrect CVC5 1.3.2 macOS ARM64 SHA256 Checksum in MODULE.bazel
Description:
The TRLC MODULE.bazel contains an incorrect SHA256 checksum for the CVC5 1.3.2 macOS ARM64 static GPL binary.
Current (incorrect) value:
Expected (correct) value:
Verification:
The correct checksum can be verified by downloading the file directly:
wget https://github.com/cvc5/cvc5/releases/download/cvc5-1.3.2/cvc5-macOS-arm64-static-gpl.zip shasum -a 256 cvc5-macOS-arm64-static-gpl.zip # Output: 6c63ba3bd174d026be161be75f64df8d200c8a284012c49e91807f3ede5afc44Bazel Impact:
checksum mismatch: expected 9b00ae44..., got 6c63ba3bd...bazel mod tidyandbazel testfrom succeeding.Impact:
Users attempting to use TRLC with Bazel's downloader/http_archive will face checksum validation failures, requiring local patches to work around the issue.
Fix:
Update the SHA256 value in
MODULE.bazelfor thecvc5_machttp_archive rule to use the correct checksum.