parlia: use parent snapshot for finalized quorum#3569
Merged
Conversation
Use the parent block's snapshot instead of the current block's snapshot when computing the validator quorum for fast finality. The current block's snapshot may reflect epoch changes (validator set transitions) that have not yet taken effect, leading to incorrect quorum thresholds.
MatusKysel
force-pushed
the
bugfix/parlia-finalized-number
branch
from
f2ddfde to
576146c
Compare
NathanBSC
approved these changes
Feb 24, 2026
allformless
approved these changes
Feb 24, 2026
zzzckck
approved these changes
Feb 24, 2026
MatusKysel
added a commit
to bnb-chain/reth-bsc
that referenced
this pull request
Feb 27, 2026
- Cap CometBFT light client validator count in decode_consensus_state to prevent DoS via oversized input (max 99 validators). - Use parent snapshot for finalized quorum calculation to avoid incorrect thresholds during epoch validator-set transitions.
MatusKysel
added a commit
to bnb-chain/reth-bsc
that referenced
this pull request
Feb 27, 2026
fix: port bsc consensus fixes (bnb-chain/bsc#3575, bnb-chain/bsc#3569)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the parent block's snapshot instead of the current block's snapshot when computing the validator quorum for fast finality. The current block's snapshot may reflect epoch changes (validator set transitions) that have not yet taken effect, leading to incorrect quorum thresholds.