Parlia voting#20
Merged
Merged
Conversation
MatusKysel
requested review from
Copilot and
will-2012
and removed request for
will-2012
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the BSC protocol implementation for handling Parlia voting in the reth-bsc client, enabling communication with the Binance Smart Chain network for consensus vote exchange. The implementation follows the BSC protocol specification and includes message handling, encoding/decoding, and integration with the reth networking stack.
Key changes:
- Implementation of BSC protocol message types (capability and votes packets)
- BSC protocol stream handler for managing connections and message exchange
- Vote pool management for collecting and deduplicating incoming votes
- Update of reth dependencies to the bnb-chain fork
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/node/network/votes.rs | New vote packet structures and encoding/decoding logic |
| src/node/network/bsc_protocol/ | Complete BSC protocol implementation with handlers and stream management |
| src/consensus/parlia/vote_pool.rs | Vote pooling and deduplication functionality |
| src/consensus/parlia/mod.rs | Module integration for vote pool |
| Cargo.toml | Dependency updates to bnb-chain reth fork |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
will-2012
approved these changes
Aug 27, 2025
will-2012
left a comment
will-2012
left a comment
Contributor
There was a problem hiding this comment.
LGTM, pls fix the failed action.
MatusKysel
force-pushed
the
parlia-voting
branch
from
544c525 to
b50b4f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts