Skip to content

chore: upgrade bnb-chain/reth to develop-v2.2 and reth-core to v0.3.1-v2#345

Draft
chee-chyuan wants to merge 1 commit into
develop-v2.1from
develop-v2.2
Draft

chore: upgrade bnb-chain/reth to develop-v2.2 and reth-core to v0.3.1-v2#345
chee-chyuan wants to merge 1 commit into
develop-v2.1from
develop-v2.2

Conversation

@chee-chyuan
Copy link
Copy Markdown

Summary

  • Bump bnb-chain/reth branch develop-v2.1develop-v2.2 (commit 048b7281)
  • Bump bnb-chain/reth-core branch v0.3.0-v2v0.3.1-v2
  • Bump alloy-evm 0.33.00.34.0; alloy-* 2.0.02.0.4

API compatibility fixes (alloy-evm 0.34.0)

  • BlockExecutorFactory: added TxExecutionResult and Executor GAT associated types; fixed create_executor lifetime/return-type signature
  • BlockExecutor::commit_transaction: now infallible (→ GasOutput); hertz patch errors deferred to finish() via new deferred_error field
  • DB: 'a bounds: removed from executor, pre_execution, and post_execution impl blocks (no longer required by trait)
  • GasOutput: extract gas via .tx_gas_used() in payload.rs and bid_simulator.rs
  • ConsensusError::Other: now takes Arc<dyn Error + Send + Sync>; wrapped string messages accordingly

Test plan

  • cargo check — passes
  • cargo build — passes
  • Run node smoke test against BSC testnet

🤖 Generated with Claude Code

- Bump bnb-chain/reth branch develop-v2.1 → develop-v2.2 (048b7281)
- Bump bnb-chain/reth-core branch v0.3.0-v2 → v0.3.1-v2
- Bump alloy-evm 0.33.0 → 0.34.0; alloy 2.0.0 → 2.0.4 crates
- Add TxExecutionResult + Executor GAT to BlockExecutorFactory impl
- Change commit_transaction to return GasOutput (infallible); defer
  hertz patch errors to finish() via deferred_error field
- Remove DB: 'a bounds from executor/pre_execution/post_execution impls
- Fix execute_transaction_with_commit_condition return type (GasOutput)
- Extract gas via .tx_gas_used() in payload/bid_simulator
- Wrap ConsensusError::Other strings in Arc<io::Error>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hashdit-bot
Copy link
Copy Markdown

hashdit-bot Bot commented May 7, 2026

Pull Request Review

This PR is a Rust/web3 node upgrade focused on dependency and API compatibility updates: it bumps bnb-chain/reth from develop-v2.1 to develop-v2.2, reth-core from v0.3.0-v2 to v0.3.1-v2, and upgrades alloy packages including alloy-evm to 0.34.0.
It also adapts internal executor and block-builder code to new alloy-evm interfaces (notably GasOutput, TxExecutionResult, GAT-based executor typing, and ConsensusError::Other now requiring Arc<dyn Error + Send + Sync>), including a deferred error pattern for commit_transaction failures surfaced in finish().
Most remaining changes are lockfile churn and branch/version alignment across root and test Cargo manifests.

Sensitive Content

Social Account:

  • https://claude.ai/claude-code (Claude Code link) in PR description — tooling attribution

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant