feat(#46): Add a flag for looking at dev-dependencies as well#169
Open
mstrydom wants to merge 1 commit intobnjbvr:mainfrom
Open
feat(#46): Add a flag for looking at dev-dependencies as well#169mstrydom wants to merge 1 commit intobnjbvr:mainfrom
mstrydom wants to merge 1 commit intobnjbvr:mainfrom
Conversation
This commit adds a naive implementation for looking at dev-dependencies. Its added as a flag, since it is a change it behaviour. This does not do anything fancy in terms of new search locations and smart classifications on location. It will also not let you know if a dependency can be moved from the main section to the dev section, but that could be a nice extension. Issue: bnjbvr#46
Author
|
This is a naive implementation for #46 . There are some option issues I would like guidance on from the maintainers:
|
Author
|
Another thing I am wondering is whether I should not add build dependencies while I am here? Maybe the flag should then just be |
Author
|
@bnjbvr Pending review |
Owner
|
Thanks for your PR, but note I'm providing work and reviews on this project on my spare time, for free. As a result, please avoid review pings. If you plan to pay me for working on this, I'd be happy to set up some consultancy contract.
Sam 24 mai 2025, à 21:33, mstrydom a écrit :
… *mstrydom* left a comment (bnjbvr/cargo-machete#169) <#169 (comment)>
@bnjbvr <https://github.com/bnjbvr> Pending review
—
Reply to this email directly, view it on GitHub <#169 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJAC46IWB7BJ2CU6UQDZZD3ADCQVAVCNFSM6AAAAAB5OSL6FKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBWHE4TAMZQGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
My apologies. I just was not sure if something needed to be done to get it on your radar (edit: or anyone else with the right permissions/ownership). Please let me know if there is anything I can do to reduce the time burden on you. |
|
A gentle reminder that the feature is wanted and the MR has been open for quite a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a naive implementation for looking at dev-dependencies. Its added as a flag, since it is a change it behaviour.
This does not do anything fancy in terms of new search locations and smart classifications on location. It will also not let you know if a dependency can be moved from the main section to the dev section, but that could be a nice extension.
Issue: #46