Skip to content

Remove unsupported option types - #6

Merged
bnomei merged 1 commit into
mainfrom
codex/github-mention-remove-unused-typed-options-without-implemen
Jun 17, 2026
Merged

Remove unsupported option types#6
bnomei merged 1 commit into
mainfrom
codex/github-mention-remove-unused-typed-options-without-implemen

Conversation

@bnomei

@bnomei bnomei commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The public option types exposed an undocumented UI state (ObjectOptions.collapsed) and a choices presentation hint (ChoicesOptions.presentation) that have no implementation and should not be part of the public surface.
  • Keep the type surface minimal and only expose options that are actually implemented by the widgets.

Description

  • Removed collapsed?: boolean from ObjectOptions in src/types.ts.
  • Removed presentation?: "radio" | "checkbox" | "toggle" from ChoicesOptions in src/types.ts.
  • Added src/types.test.ts with focused TypeScript assertions that valid options satisfy the exported types and that the removed properties produce @ts-expect-error when present.
  • Did not add any UI behavior or surface changes to the admin widgets and left documentation unchanged because README did not reference the removed fields.

Testing

  • Ran type checking with npm run typecheck and it passed.
  • Ran formatting/lint checks with npm run check (which runs vp check .) and it passed.
  • Built the package with npm run build and the build completed successfully.

Codex Task

Closes #2

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@augmentcode

augmentcode Bot commented Jun 17, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR trims the public TypeScript option surface by removing two unsupported widget options.

Changes:

  • Removed collapsed?: boolean from ObjectOptions and presentation?: ... from ChoicesOptions.
  • Added src/types.test.ts with type-level assertions using satisfies for valid configs.
  • Included negative assertions via @ts-expect-error to ensure the removed properties now fail type-checking.

Technical Notes: Since tsconfig.json includes src, the new type test file is covered by tsc --noEmit without affecting published artifacts (only dist is shipped).

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bnomei, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 56 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7f87a61-5d5e-47ea-a44f-8a38556c5989

📥 Commits

Reviewing files that changed from the base of the PR and between 40d08cf and 50d1e4b.

📒 Files selected for processing (2)
  • src/types.test.ts
  • src/types.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bnomei
bnomei merged commit 40bfa3d into main Jun 17, 2026
1 check passed
@bnomei
bnomei deleted the codex/github-mention-remove-unused-typed-options-without-implemen branch June 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused typed options without implementation

1 participant