Optimize JsStr::code_points() for Latin1 strings#4553
Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom Dec 2, 2025
Merged
Optimize JsStr::code_points() for Latin1 strings#4553jedel1043 merged 2 commits intoboa-dev:mainfrom
jedel1043 merged 2 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4553 +/- ##
==========================================
+ Coverage 47.24% 57.14% +9.90%
==========================================
Files 476 504 +28
Lines 46892 57558 +10666
==========================================
+ Hits 22154 32893 +10739
+ Misses 24738 24665 -73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
reviewed
Dec 1, 2025
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
I have a small suggestion about the new test. Everything else looks good!
jedel1043
added
A-Enhancement
jedel1043
reviewed
Dec 1, 2025
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Final round of comments and we can review after that. Thank you for the contribution!
Member
|
Ah, you may have to add "Caf" to the list of excluded words in |
- Add CodePointIter with specialized Latin1 path - Latin1 strings avoid UTF-16 conversion overhead - UTF-16 behavior remains unchanged - Add tests for both encoding paths - Include Latin1-compatible characters in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request optimizes the
code_points()method for Latin1 strings.It changes the following:
CodePointIterenum with specialized Latin1 path