Optimize Array.prototype.push and pop with dense fast paths #5281#5282
Closed
dhruveshmishra wants to merge 1 commit intoboa-dev:mainfrom
Closed
Optimize Array.prototype.push and pop with dense fast paths #5281#5282dhruveshmishra wants to merge 1 commit intoboa-dev:mainfrom
dhruveshmishra wants to merge 1 commit intoboa-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces fast-path optimizations for
Array.prototype.popandArray.prototype.pushwhen operating on dense arrays.Closes #5281
Currently, push and pop operations go through generic property access, which introduces unnecessary overhead. Since most arrays are dense, we can directly operate on underlying storage.
Implementation
dense_indexed_properties_mut()vec.pop()andvec.push()for performancevec.len() == lengthdrop(obj)Testing
cargo test)Notes
Optimization is applied conservatively to maintain correctness.