Skip to content

fix request signal#5288

Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom
Monti-27:fetch-request-signal
Apr 9, 2026
Merged

fix request signal#5288
jedel1043 merged 1 commit intoboa-dev:mainfrom
Monti-27:fetch-request-signal

Conversation

@Monti-27
Copy link
Copy Markdown
Contributor

Fixes #5286.

This makes fetch(request) use the signal stored on the Request object.
It also keeps fetch level signal overrides working the same way.

Tests:

  • cargo test -p boa_runtime --lib
  • cargo clippy -p boa_runtime --all-features --all-targets -- -D warnings

@Monti-27 Monti-27 requested a review from a team as a code owner March 30, 2026 21:28
@github-actions github-actions bot added the Waiting On Review Waiting on reviews from the maintainers label Mar 30, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 30, 2026
@github-actions github-actions bot added C-Tests Issues and PRs related to the tests. C-Runtime Issues and PRs related to Boa's runtime features labels Mar 30, 2026
@github-actions
Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,735 50,735 0
Ignored 1,426 1,426 0
Failed 802 802 0
Panics 0 0 0
Conformance 95.79% 95.79% 0.00%

Tested main commit: f5e88de558e038f0ae675a012d59917a098f44b6
Tested PR commit: 96081c42d51d8d5927c8fa95891085a0635a2956
Compare commits: f5e88de...96081c4

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.72%. Comparing base (6ddc2b4) to head (96081c4).
⚠️ Report is 946 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5288       +/-   ##
===========================================
+ Coverage   47.24%   59.72%   +12.47%     
===========================================
  Files         476      589      +113     
  Lines       46892    63490    +16598     
===========================================
+ Hits        22154    37917    +15763     
- Misses      24738    25573      +835     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😄

@jedel1043 jedel1043 added this pull request to the merge queue Apr 8, 2026
Merged via the queue into boa-dev:main with commit 352ec3d Apr 9, 2026
22 checks passed
@github-actions github-actions bot removed the Waiting On Review Waiting on reviews from the maintainers label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch(request) ignores Request.signal

3 participants