feat(compiler): Generate single emit opcode for negative numbers#5305
Open
HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
Open
feat(compiler): Generate single emit opcode for negative numbers#5305HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
eee10fc to
0a10662
Compare
b3cec33 to
719bb68
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5305 +/- ##
===========================================
+ Coverage 47.24% 59.68% +12.43%
===========================================
Files 476 589 +113
Lines 46892 63661 +16769
===========================================
+ Hits 22154 37994 +15840
- Misses 24738 25667 +929 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small optimization that replaces the generated output for simple negative numbers, previously emitting
StoreInt8followed byNeg, with a singleStoreInt8instruction that directly emits the negative value.