feat(compiler): Generate optimized code for ToInt32 code patterns#5307
Open
HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
Open
feat(compiler): Generate optimized code for ToInt32 code patterns#5307HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
ToInt32 code patterns#5307HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5307 +/- ##
===========================================
+ Coverage 47.24% 59.72% +12.48%
===========================================
Files 476 589 +113
Lines 46892 63663 +16771
===========================================
+ Hits 22154 38023 +15869
- Misses 24738 25640 +902 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new bytecode instruction,
ToInt32, to the engine's virtual machine. The main purpose of this change is to optimize certain bitwise operations by emitting a specialized instruction for converting values to 32-bit integers, particularly for common JavaScript idioms likex | 0andx & 0xFFFFFFFF.