Skip to content

Implement support for compact formatting in NumberFormat#5312

Open
jedel1043 wants to merge 1 commit intoboa-dev:mainfrom
jedel1043:compact-decimal-formatter
Open

Implement support for compact formatting in NumberFormat#5312
jedel1043 wants to merge 1 commit intoboa-dev:mainfrom
jedel1043:compact-decimal-formatter

Conversation

@jedel1043
Copy link
Copy Markdown
Member

Implements compact formatting for NumberFormat with ICU4X 2.2's newly introduced (but unstable) CompactDecimalFormatter.

Not worried about using unstable since this change only affects how we handle NumberFormat construction.

@jedel1043 jedel1043 requested review from a team and nekevss as code owners April 9, 2026 23:22
@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Dependencies Pull requests that update a dependency file C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation and removed Waiting On Review Waiting on reviews from the maintainers labels Apr 9, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,049 51,051 +2
Ignored 1,482 1,482 0
Failed 594 592 -2
Panics 0 0 0
Conformance 96.09% 96.10% +0.00%
Fixed tests (2):
test/intl402/NumberFormat/prototype/format/useGrouping-extended-en-IN.js (previously Failed)
test/intl402/NumberFormat/prototype/format/useGrouping-extended-en-US.js (previously Failed)

Tested main commit: d6d76d86e9e18fca07f318f1db434cc8abffaf14
Tested PR commit: 485349eebdc2bb3b51948aa88a3272d44fe66ec2
Compare commits: d6d76d8...485349e

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 27.86885% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.81%. Comparing base (6ddc2b4) to head (485349e).
⚠️ Report is 947 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/intl/number_format/mod.rs 27.11% 43 Missing ⚠️
core/engine/src/builtins/bigint/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5312       +/-   ##
===========================================
+ Coverage   47.24%   59.81%   +12.56%     
===========================================
  Files         476      589      +113     
  Lines       46892    63699    +16807     
===========================================
+ Hits        22154    38101    +15947     
- Misses      24738    25598      +860     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Dependencies Pull requests that update a dependency file C-Intl Changes related to the `Intl` implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant