-
Notifications
You must be signed in to change notification settings - Fork 40
Implement toZonedDateTime in PlainDate #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nekevss
merged 17 commits into
boa-dev:main
from
JohannesHelleve:impl-to-zoned-date-time
Apr 7, 2025
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3fd2fa3
Not sure check is an object is correct and type of item
JohannesHelleve ba8c8ab
clean up
JohannesHelleve 48fcbb6
added match stmt
JohannesHelleve f769e2a
cleaner code
JohannesHelleve d1556af
Merge branch 'main' into impl-to-zoned-date-time
JohannesHelleve 4d5fbca
Utilized already existing fn, created api, some variable change & cle…
JohannesHelleve 9c1752a
Merge branch 'main' into impl-to-zoned-date-time
JohannesHelleve 9a80a4d
updated with some tips, getting closer
JohannesHelleve e5e4e60
fetched
JohannesHelleve 03a5bdd
merged
JohannesHelleve 4147b16
added back wrongly merged code
JohannesHelleve 292b00a
created tests
JohannesHelleve deb7cc1
Merge branch 'main' into impl-to-zoned-date-time
JohannesHelleve 49072bf
feature flag only for own test
JohannesHelleve cb6550c
Merge branch 'impl-to-zoned-date-time' of github.com:JohannesHelleve/…
JohannesHelleve 4c2ce7b
Merge branch 'main' into impl-to-zoned-date-time
JohannesHelleve a9b0747
running lint command
JohannesHelleve File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the feature configuration shouldn't be here I think. You should be able to configure specific tests. With
#[cfg(feature = "tzdb"]above the specific tests. I think references can be found in other test modules.