Conversation
jedel1043
approved these changes
Mar 20, 2025
| let system_nanos = sys::get_system_nanoseconds()?; | ||
| let epoch_nanos = EpochNanoseconds::try_from(system_nanos)?; | ||
| Now::plain_time_iso_with_provider(epoch_nanos, timezone, &*provider) | ||
| Now::plain_time_iso_with_provider_and_system_info(epoch_nanos, timezone, &*provider) |
Member
There was a problem hiding this comment.
Thought: I'm not against merging this as it is, but I think it would be worth looking into having a builder API instead of two functions with slightly different arguments. Could be hard to have the same semantics through FFI though, so it'd require a bit of thinking.
Member
Author
There was a problem hiding this comment.
Yeah, I'm up for adjustments or rethinking Now's API. A builder pattern could actually be really nice. The main goal here was to mostly align the method names a little bit better with the rest of the crate and add tests.
I'm really not in love with the names, but at the very least they are specific. We should open an issue for the builder pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
Nowcore API and adds a test using mock system data.The two goals of this PR are the API and implementing at least one more
Nowtest. As far as the API goal, this PR attempts to make the API a bit more explicit and clear. If there's any suggestion for a better method name for the core methods, please feel free to provide feedback.In the future, we should could add more now unit tests using mock data to ensure the behavior is stable and as expected.