Remove the Temporal prefix from Unit, RoundingMode, and UnsignedRoundingMode#254
Merged
Remove the Temporal prefix from Unit, RoundingMode, and UnsignedRoundingMode#254
Conversation
Contributor
|
The capi already uses a temporal_rs cpp namespace, so I don't think we need more prefixing. But we can experiment a bunch with the naming, Diplomat provides rich control over renaming things. |
nekevss
force-pushed
the
remove-temporal-prefix
branch
from
18702b9 to
e88adf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #222.
The background was mentioned in the initial issue. But to restate for this PR,
TemporalUnit,TemporalRoundingMode, andTemporalUnsignedRoundingModecome from the very early days of temporal_rs, dating alway back to the initial merge into Boa. The explicit name was to prevent any clashing withIntl. With temporal_rs pulled out of Boa and standing more formally as it's own crate, it's long been overdue to remove the prefix as it is redundant.The general proposal is to change the below names:
temporal_rs::options::TemporalUnit->temporal_rs::options::Unittemporal_rs::options::TemporalRoundingMode->temporal_rs::options::RoundingModetemporal_rs::options::TemporalUnsignedRoundingMode->temporal_rs::options::UnsignedRoundingModeCC: @Manishearth
The change in this PR also currently extends to
temporal_capi. Would there be a preference around keeping the more explicit temporal prefix, or would there not be much of an effect either way in your opinion?