Verify all deposits are included #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
force-pushed
the
jyelliick/verify-all-deposits-are-included
branch
from
6661953 to
1eae0f6
Compare
boyuan-chen
approved these changes
May 8, 2024
mmontour1306
approved these changes
May 8, 2024
jyellick
force-pushed
the
jyelliick/verify-all-deposits-are-included
branch
from
1eae0f6 to
fe563da
Compare
This additionally removes the 'abort' path inside of the add mining txes code when dealing with deposit txes.
jyellick
force-pushed
the
jyelliick/verify-all-deposits-are-included
branch
from
fe563da to
7262d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a WIP -- I don't strictly see any problem with is, but wanted to get some additional feedback.