streams: put NHDPlus HR on the map, stop styling base NHD on Klamath-only STREAMORDER - #116
streams: put NHDPlus HR on the map, stop styling base NHD on Klamath-only STREAMORDER#116cboettig wants to merge 2 commits into
Conversation
…only STREAMORDER The map half of #111 was deferred until data-workflows#205 landed. It has. - Add usgs-nhdplus-hr-flowline (flowline-pmtiles) as "Stream Order (NHDPlus HR)", width and tooltip on `streamorde` — populated on 100% of in-network non-coastline length, so the width expression now has an input everywhere. - The base NHD layer keeps extent only: rename to "Stream Extent (NHD)", drop the STREAMORDER width interpolation and the STREAMORDER tooltip field. That field is empty outside HUC4 1801, so 91% of California's flowlines rendered at the expression's fallback width and hovered an empty attribute. - AGENTS.md: the streams row said "App rule pending; upstream in progress" with a 13-basin 99.65% figure. Upstream is closed, the rule shipped in #112/#114, and the row now carries the lesson that cost the run — the collection is national and unclipped, so mask to California. Refs #111
Gate: green
No timeouts on either tier. Compliance axis moved in both directions and neither is this branchJudged compliance came out 14/18 (regression) and 11/16 (glm commentary) here against 16–17/18 and 10/16 on
The same cells flip verdicts between two judgings of unchanged answers, so I would not read a 2-cell compliance move on this tier as signal in either direction. Not addressed here, deliberatelyThe one real defect the gate exposed is that a model can route and mask correctly and still weight the conserved fraction by cell area instead of stream length — 25.47 vs 27.46 on identical input, reproduced exactly. That is generic SQL method, not app interpretation, so per |
|
Pushed |
Closes the two map-layer loose ends #111 deferred until data-workflows#205 landed, and refreshes the AGENTS.md row that still described the problem as open.
The map was still styled on the broken field
layers-input.jsondrew "Streams by Order (NHD)" withline-widthinterpolated on["get","STREAMORDER"]and exposedSTREAMORDERon hover. That attribute is populated on 8.7% of California's flowlines, 97.8% of it HUC4 1801 — so outside the Klamath the width expression had no input and the tooltip field read empty. #111 flagged it and deliberately deferred rather than paper over it.usgs-nhdplus-hr-flowlinestreamordeusgs-nhd-streams-by-orderSTREAMORDERThe split matches the routing rule already in
system-prompt.md: order and network attributes from NHDPlus HR, extent and flow permanence from base NHD. Display names now say which layer is which so the toggle list does not offer two things called "by order".Asset ids and field names verified against the published PMTiles, not the parquet schema:
Tiles are display-only — tippecanoe dropped features on dense tiles, so no quantity should ever be computed from them. That is a data-layer property and is documented in the collection.
AGENTS.md row was stale
The streams row read "App rule pending; upstream in progress", cited "99.65% coverage across all 13 CA basins", and said NHDPlus HR "is being added alongside". All three upstream issues are closed, coverage is 100.00% across 266 national units, and the rule shipped in #112/#114.
More importantly it did not carry the lesson that actually cost a gate run: the collection is national and clipped to nothing, so an unmasked California query reads 924,634 km against 641,393 km in-state and 19.0% conserved against 27.5% — the same mechanism as the pinyon-juniper row directly above it. The rewritten row leads with the routing rule and the mask, keeps the four ruled-out investigations (now including the false "H3 can only measure area" premise), and keeps the standing expectation that our lengths run ~3x the partner's forever.
Gate
regression+commentaryonz-ai/glm-5.2+deepseek/deepseek-v4-flash-0731. Adding a collection tolayers-input.jsonchanges what the agent sees at prompt-assembly time, so this is gated rather than shipped on inspection even though no SQL guidance changed.Refs #111