fix: strengthen error handling in demo and validation scripts#9
Open
boffin-dmytro wants to merge 2 commits intomainfrom
Open
fix: strengthen error handling in demo and validation scripts#9boffin-dmytro wants to merge 2 commits intomainfrom
boffin-dmytro wants to merge 2 commits intomainfrom
Conversation
boffin-dmytro
force-pushed
the
main
branch
2 times, most recently
from
5a4c90a to
28da306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens error handling in 5 demo and validation scripts by upgrading from
set -etoset -euo pipefail.Changes
Problem Solved
These scripts used
set -ewhich only catches command failures, but not:-uflag)-o pipefail)Benefits
$UNDEFINEED_VARcurl | jqfails if curl fails, not just if jq failsTesting
All scripts validated with
bash -nfor syntax correctness.