ENH: add transform-log action - #6
Open
VinzentRisch wants to merge 17 commits into
Open
Conversation
ebolyen
reviewed
Feb 5, 2026
| ) | ||
|
|
||
| plugin.methods.register_function( | ||
| function=transform_log, |
There was a problem hiding this comment.
I wonder if we should be even more suggestive than this. i.e. transform_<omic> and then we have a variety of methods available which are suitably justified.
Really quite similar to your feature table normalization already.
| parameters={ | ||
| "pseudocount": Float % Range(0, None, inclusive_start=False), | ||
| }, | ||
| outputs=[("log_table", FeatureTable[Composition])], |
There was a problem hiding this comment.
This is actually not quite a composition, I'm not sure what it is actually as it's also not frequency anymore since I assume MS data will yield negative values after log-transform.
Closed
|
This PR/issue depends on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2
depends on #5
depends on qiime2/q2-types#383
Added action to log transform a feature table with pseudocount.