Replace Settings/Option layer with direct Config usage #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the intermediate Settings representation and Option type (Some/None) abstraction in favor of using Domain::Config directly with the existing Undefined sentinel pattern. Previously, defaults were injected lazily at light creation time. Settings tracked whether each value was explicitly configured (Some) or not (None), and ConfigurationPipeline resolved None values to defaults at the end. Now, configuration starts with DefaultConfig containing all default values, and user-provided values extend/override them immediately via Config#with. This "defaults-first" approach is simpler and makes the effective configuration visible earlier in the pipeline. Old flow: User DSL → Settings (Option-wrapped) → ConfigurationPipeline → Config (defaults injected here) New flow: DefaultConfig → extend with user values → Config (validated) (starts with defaults) This reduces indirection and makes the configuration flow clearer. ConfigurationDsl handles interpreting user-friendly values (symbols, single error classes) into canonical forms before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the intermediate Settings representation and Option type (Some/None)
abstraction in favor of using Domain::Config directly with the existing
Undefined sentinel pattern.
Previously, defaults were injected lazily at light creation time. Settings
tracked whether each value was explicitly configured (Some) or not (None),
and ConfigurationPipeline resolved None values to defaults at the end.
Now, configuration starts with DefaultConfig containing all default values,
and user-provided values extend/override them immediately via Config#with.
This "defaults-first" approach is simpler and makes the effective
configuration visible earlier in the pipeline.
Old flow:
User DSL → Settings (Option-wrapped) → ConfigurationPipeline → Config
(defaults injected here)
New flow:
DefaultConfig → extend with user values → Config (validated)
(starts with defaults)
This reduces indirection and makes the configuration flow clearer.
ConfigurationDsl handles interpreting user-friendly values (symbols,
single error classes) into canonical forms before merging.