Skip to content

Add option to install config or not#1050

Open
fufexan wants to merge 1 commit intoboltgolt:masterfrom
fufexan:optional-install-config
Open

Add option to install config or not#1050
fufexan wants to merge 1 commit intoboltgolt:masterfrom
fufexan:optional-install-config

Conversation

@fufexan
Copy link
Contributor

@fufexan fufexan commented Oct 13, 2025

Add option install_config that allows users to enable/disable installing the config.

Needed on NixOS to preserve the path to a read-only /etc/howdy/config.ini.

@fufexan fufexan mentioned this pull request Oct 13, 2025
17 tasks
Copy link

@MaricanEngineering MaricanEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I approve


fs = import('fs')
if not fs.exists(config_path)
if get_option('install_config') and not fs.exists(config_path)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding option to not add config

option('install_in_site_packages', type: 'boolean', value: false, description: 'Install howdy python files in site packages')
option('py_sources_dir', type: 'string', value: '', description: 'Set the python sources directory')
option('install_pam_config', type: 'boolean', value: false, description: 'Install pam config file (for Debian/Ubuntu)')
option('install_config', type: 'boolean', value: true, description: 'Install Howdy config file')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding option to install config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments