Skip to content

(VIBE CODED) Fix GTK authentication window not closing automatically #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nafg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(VIBE CODED) Fix GTK authentication window not closing automatically #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion howdy-gtk/src/authsticky.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,15 @@ def draw(self, widget, ctx):
def catch_stdin(self):
"""Catch input from stdin and redraw"""
# Wait for a line on stdin
comm = sys.stdin.readline()[:-1]
comm = sys.stdin.readline()

# If EOF (empty string), exit
if not comm:
self.exit(None, None)
return False

# Strip newline
comm = comm[:-1]

# If the line is not empty
if comm:
Expand Down
12 changes: 10 additions & 2 deletions howdy/src/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,16 @@ def exit(code=None):
global gtk_proc

# Exit the auth ui process if there is one
if "gtk_proc" in globals():
gtk_proc.terminate()
if "gtk_proc" in globals() and gtk_proc is not None:
try:
# Try to close stdin to signal EOF to the GTK process
gtk_proc.stdin.close()
# Give it a moment to exit gracefully
gtk_proc.wait(timeout=0.5)
except:
# Force kill if it doesn't exit gracefully
gtk_proc.kill()
gtk_proc.wait()

# Exit compare
if code is not None:
Expand Down