Decouple alternate buffer switching from clearing#14
Merged
Conversation
Add `{ clear?: boolean }` option to `ALTSCREEN()` and
`alternateBuffer()`. When `clear` is false, uses xterm private mode 47
to switch without clearing the alternate buffer contents.
Closes #13
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
alternateBuffer()uses xterm private mode 1049, which clears the alternate buffer every time it is entered. This makes it impossible to toggle between main and alternate buffers without losing the alternate buffer's contents.Closes #13
Approach
Add a
{ clear?: boolean }option toALTSCREEN()in termcodes.ts. Whenclearisfalse, it emits mode 47 instead of 1049, which switches to the alternate buffer without clearing it. The option is threaded throughalternateBuffer()in settings.ts.MAINSCREEN()always uses mode 1049 since the clear concern only applies on entry.