Surface Clay layout errors on RenderResult#23
Merged
Conversation
Clay reports errors (duplicate IDs, capacity exceeded, etc.) via a callback during layout. These were previously silently discarded. Collect them per-render on the Clayterm struct and expose them as `errors: ClayError[]` on RenderResult.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Clay reports errors during layout (duplicate IDs, capacity exceeded, unbalanced open/close, etc.) via a callback. These were silently discarded, making it impossible for callers to know when their layout had issues.
Approach
errorsanderror_countfields to theClaytermstruct (no global state)clay_errorcallback receives theClayterminstance via Clay'suserDatapointer and appends errors to the per-instance bufferreduce()call, so each render returns only its own errorserror_count,error_type,error_message_length,error_message_ptras WASM exportsterm-native.tstoterm.ts, addingerrors: ClayError[]toRenderResult