This repository was archived by the owner on Jul 29, 2022. It is now read-only.
Sorting by caption and showing selected on top is now optional #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected options at the top
jbreitung
changed the title
|
Looks good, but sorting by caption/by value is not respected in this method updateSelectedItemsCaption(). The input caption is generated based on selection order. It would be good to unify this behavior (if possible). But it's working very well. Thank you |
added 2 commits
September 23, 2020 08:32
Conflicts: vaadin-combobox-multiselect-addon/src/main/java/org/vaadin/addons/ComboBoxMultiselect.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a flag which allows to enable/disable the soring of entries by their caption. Also added a new flag which allows to enable/disable displaying selected entries on top.