Skip to content

Prune quantifier variables #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
keyboardDrummer wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Prune quantifier variables #1028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e65402
Fixes
keyboardDrummer Jun 27, 2025
3ab4a7b
Bring back error message
keyboardDrummer Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 32 additions & 18 deletions Source/Core/AST/AbsyQuant.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ public override void Resolve(ResolutionContext rc)
kv.Resolve(rc);
}

this.ResolveTriggers(rc);
Body.Resolve(rc);
this.ResolveTriggers(rc);
rc.PopVarContext();

// establish a canonical order of the type parameters
Expand Down Expand Up @@ -730,27 +730,41 @@ private void ApplyNeverTriggers()

protected override void ResolveTriggers(ResolutionContext rc)
{
for (Trigger tr = this.Triggers; tr != null; tr = tr.Next)
var freeBodyVars = new Set();
Body.ComputeFreeVariables(freeBodyVars);

// No idea why this copy is necessary. Why would dummies be shared?
Dummies = Dummies.ToList();

for (var tr = this.Triggers; tr != null; tr = tr.Next)
{
int prevErrorCount = rc.ErrorCount;
tr.Resolve(rc);
if (prevErrorCount == rc.ErrorCount)
{
// for positive triggers, make sure all bound variables are mentioned
if (tr.Pos)
{
Set /*Variable*/
freeVars = new Set /*Variable*/();
tr.ComputeFreeVariables(freeVars);
foreach (Variable v in Dummies)
{
Contract.Assert(v != null);
if (!freeVars[v])
{
rc.Error(tr, "trigger must mention all quantified variables, but does not mention: {0}", v);
}
}
if (prevErrorCount != rc.ErrorCount) {
continue;
}

// for positive triggers, make sure all bound variables are mentioned
if (!tr.Pos) {
continue;
}

var freeVarsTrigger = new Set();
tr.ComputeFreeVariables(freeVarsTrigger);
for (var index = 0; index < Dummies.Count; index++) {
var variable = Dummies[index];
Contract.Assert(variable != null);
if (freeVarsTrigger[variable]) {
continue;
}

if (freeBodyVars.Contains(variable)) {
rc.Error(tr, "trigger must mention all quantified variables, but does not mention: {0}", variable);
} else {
Dummies.RemoveAt(index);
index--;
}

}
}
}
Expand Down
Loading