ci: adding a test for recursive dependencies

Make sure we have a test with a fake lock file that simulates a totally
circular dependency tree to validate that starlark behaves as expected

Author: manuelnaranjo

.github/workflows/action.yml

@@ -169,5 +169,5 @@ jobs:
           import %workspace%/../../.github/workflows/ci.bazelrc
     - id: prepare
       run: |
-        cd e2e/bzlmod-toolchain-circular-dependencies
-        make test
+        (cd e2e/bzlmod-toolchain-circular-dependencies && make test)
+        (cd e2e/bzlmod-toolchain-circular-dependencies-fake && make test)

Makefile

@@ -69,13 +69,23 @@ e2e-bzlmod-toolchain-circular-dependencies:
 		) \
 	done
 
+e2e-bzlmod-toolchain-circular-dependencies-fake:
+	@for version in 7.x 8.x; do \
+		( \
+			cd e2e/bzlmod-toolchain-circular-dependencies-fake && \
+			echo "Testing $$version bzlmod lock file from args" > /dev/stderr && \
+			USE_BAZEL_VERSION=$$version bazelisk --batch build //...  \
+		) \
+	done
+
 
 e2e: e2e-workspace \
 	e2e-bzlmod \
 	e2e-bzlmod-build-toolchain \
 	e2e-bazel-bzlmod-lock-file \
 	e2e-bazel-bzlmod-lock-file-from-args \
-	e2e-bzlmod-toolchain-circular-dependencies
+	e2e-bzlmod-toolchain-circular-dependencies \
+	e2e-bzlmod-toolchain-circular-dependencies-fake
 
 fmt: gofmt buildifier
 

e2e/bzlmod-toolchain-circular-dependencies-fake/BUILD

@@ -0,0 +1,22 @@
+load("@bazeldnf//bazeldnf:defs.bzl", "rpmtree")
+
+rpmtree(
+    name = "rpms-circular-triplet-package-1",
+    rpms = [
+        "@rpms-circular-triplet//package1",
+    ],
+)
+
+rpmtree(
+    name = "rpms-circular-triplet-package-2",
+    rpms = [
+        "@rpms-circular-triplet//package2",
+    ],
+)
+
+rpmtree(
+    name = "rpms-circular-triplet-package-3",
+    rpms = [
+        "@rpms-circular-triplet//package3",
+    ],
+)

e2e/bzlmod-toolchain-circular-dependencies-fake/MODULE.bazel

@@ -0,0 +1,65 @@
+"example MODULE.bazel to test bzlmod integration for bazeldnf without a prebuilt toolchain"
+
+bazel_dep(name = "bazeldnf", dev_dependency = True)
+local_path_override(
+    module_name = "bazeldnf",
+    path = "../..",
+)
+
+bazel_dep(name = "rules_pkg", version = "1.0.1")
+bazel_dep(name = "rules_go", version = "0.53.0", repo_name = "rules_go")
+
+go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
+go_sdk.download(version = "1.24.1")
+
+bazel_dep(name = "gazelle", version = "0.42.0")
+bazel_dep(name = "toolchains_protoc", version = "0.3.7")
+
+protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc")
+protoc.toolchain(
+    google_protobuf = "com_google_protobuf",
+    version = "v27.3",
+)
+use_repo(protoc, "com_google_protobuf", "toolchains_protoc_hub")
+
+register_toolchains(
+    "@toolchains_protoc_hub//:all",
+    dev_dependency = True,
+)
+
+go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
+go_deps.from_file(go_mod = "@bazeldnf//:go.mod")
+use_repo(
+    go_deps,
+    "com_github_adrg_xdg",
+    "com_github_bazelbuild_buildtools",
+    "com_github_crillab_gophersat",
+    "com_github_jdx_go_netrc",
+    "com_github_klauspost_compress",
+    "com_github_onsi_gomega",
+    "com_github_sassoftware_go_rpmutils",
+    "com_github_sirupsen_logrus",
+    "com_github_spf13_cobra",
+    "io_k8s_sigs_yaml",
+    "org_golang_x_crypto",
+    "org_golang_x_exp",
+)
+
+bazeldnf_toolchain = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf_toolchain")
+bazeldnf_toolchain.register(disable = True)
+
+bazeldnf = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf")
+bazeldnf.config(
+    name = "rpms-circular-triplet",
+    ignore_deps = False,
+    lock_file = "//:rpms-circular-triplet.json",
+    rpms = [
+        "package1",
+        "package2",
+        "package3",
+    ],
+)
+use_repo(
+    bazeldnf,
+    "rpms-circular-triplet",
+)

e2e/bzlmod-toolchain-circular-dependencies-fake/Makefile

@@ -0,0 +1,4 @@
+all: test
+
+test:
+	bazelisk query 'deps(@rpms-circular-triplet//...)' --output build

e2e/bzlmod-toolchain-circular-dependencies-fake/rpms-circular-triplet.json

@@ -0,0 +1,44 @@
+{
+    "cli-arguments": [],
+    "name": "",
+    "repositories": {
+        "fake-repository": [
+            "https://mirror.stream.centos.org/9-stream/BaseOS/x86_64/os"
+        ]
+    },
+    "rpms": [
+        {
+            "name": "package1",
+            "urls": [
+                "Packages/audit-libs-3.1.5-4.el9.x86_64.rpm"
+            ],
+            "repository": "fake-repository",
+            "dependencies": [
+                "package2",
+                "package3"
+            ]
+        },
+        {
+            "name": "package2",
+            "urls": [
+                "Packages/bash-5.1.8-9.el9.x86_64.rpm"
+            ],
+            "repository": "fake-repository",
+            "dependencies": [
+                "package1",
+                "package3"
+            ]
+        },
+        {
+            "name": "package3",
+            "urls": [
+                "Packages/bzip2-libs-1.0.8-10.el9.x86_64.rpm"
+            ],
+            "repository": "fake-repository",
+            "dependencies": [
+                "package1",
+                "package2"
+            ]
+        }
+    ]
+}