Fix startup fatal hangs not persisting to disk in UI tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix: Add UserDefaults.synchronize() to force immediate disk persistence This ensures hang info is saved before app termination during fatal hangs - Add .startupFatalHang message type to distinguish from regular fatal hangs - Add UI test testStartupFatalHang() that validates the fix works in Release mode - Add support for simulating startup fatal hangs in test environment The root cause was that UserDefaults doesn't immediately persist to disk, so when the system killed the app during a fatal hang, the hang information was lost. Now synchronize() forces immediate disk writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add
UserDefaults.synchronize()to force immediate disk persistence This ensures hang info is saved before app termination during fatal hangsAdd
.startupFatalHangmessage type to distinguish from regular fatal hangs in UI testsAdd UI test
testStartupFatalHang()that validates the fix works in Release modeAdd support for simulating startup fatal hangs in test environment