Skip to content

fix(reader): show selection popup below text on Android to avoid native action bar conflict #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
croakingtoad wants to merge 2 commits into
base: develop
Choose a base branch
from
+10 −6
Open

fix(reader): show selection popup below text on Android to avoid native action bar conflict #3398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a83ec
fix: show selection popup below text on mobile (Android)
May 6, 2026
eed8dac
fix: run text-selected emission inside NgZone for immediate change de…
May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions booklore-ui/src/app/features/readers/ebook-reader/core/event.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {inject, Injectable} from '@angular/core';
import {inject, Injectable, NgZone} from '@angular/core';
import {Subject} from 'rxjs';
import {ReaderAnnotationService} from '../features/annotations/annotation-renderer.service';

Expand Down Expand Up @@ -33,6 +33,7 @@ export class ReaderEventService {
private readonly SWIPE_THRESHOLD_PX = 50;

private annotationService = inject(ReaderAnnotationService);
private ngZone = inject(NgZone);

private view: any;
private viewCallbacks: ViewCallbacks | null = null;
Expand Down Expand Up @@ -395,7 +396,8 @@ export class ReaderEventService {
}

const minSpaceAbove = 120;
const showBelow = selectionTop < minSpaceAbove;
const isMobile = 'ontouchstart' in window || navigator.maxTouchPoints > 0;
const showBelow = isMobile || selectionTop < minSpaceAbove;

let popupY: number;
if (showBelow) {
Expand All @@ -406,10 +408,12 @@ export class ReaderEventService {

popupX = Math.max(100, Math.min(popupX, window.innerWidth - 150));

this.eventSubject.next({
type: 'text-selected',
detail: {text, cfi, range, index},
popupPosition: {x: popupX, y: popupY, showBelow}
this.ngZone.run(() => {
this.eventSubject.next({
type: 'text-selected',
detail: {text, cfi, range, index},
popupPosition: {x: popupX, y: popupY, showBelow}
});
});
}
}, 10);
Expand Down