Skip to content

test: close Files.list streams - #199

Merged
boolivar merged 1 commit into
masterfrom
list-files
Aug 15, 2026
Merged

test: close Files.list streams#199
boolivar merged 1 commit into
masterfrom
list-files

Conversation

@boolivar

@boolivar boolivar commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Greptile Summary

The PR replaces direct Files.list calls in the test suite with a helper that closes each directory stream after collecting its paths.

  • Adds a try-with-resources helper for listing directory contents.
  • Updates three assertions to use the resource-safe helper.

Confidence Score: 5/5

The PR appears safe to merge.

The helper fully consumes each directory stream before the try-with-resources scope closes it, returning the same list shape used by the existing assertions without changing test behavior.

Important Files Changed

Filename Overview
jdoc-cucumber-gradle-plugin/src/test/java/org/bool/jdoc/cucumber/gradle/JdocCucumberActionTest.java Test directory listings now use a try-with-resources helper that preserves existing assertion behavior while reliably closing each stream.

Reviews (1): Last reviewed commit: "test: close Files.list streams" | Re-trigger Greptile

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (1a6e46a) to head (c8da668).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage     90.26%   90.26%           
  Complexity      172      172           
=========================================
  Files            36       36           
  Lines           483      483           
  Branches         21       21           
=========================================
  Hits            436      436           
  Misses           40       40           
  Partials          7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boolivar
boolivar merged commit 0d8604a into master Aug 15, 2026
9 checks passed
@boolivar
boolivar deleted the list-files branch August 15, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant