test: close Files.list streams - #199
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
=========================================
Coverage 90.26% 90.26%
Complexity 172 172
=========================================
Files 36 36
Lines 483 483
Branches 21 21
=========================================
Hits 436 436
Misses 40 40
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR replaces direct
Files.listcalls in the test suite with a helper that closes each directory stream after collecting its paths.Confidence Score: 5/5
The PR appears safe to merge.
The helper fully consumes each directory stream before the try-with-resources scope closes it, returning the same list shape used by the existing assertions without changing test behavior.
Important Files Changed
Reviews (1): Last reviewed commit: "test: close Files.list streams" | Re-trigger Greptile